Enable multi-language repo search and selection#244
Enable multi-language repo search and selection#244max-programming merged 18 commits intomax-programming:mainfrom
Conversation
Updated the hero component to allow users to select multiple programming languages via checkboxes, both from main and 'other' languages. Modified the repo page logic to accept and process multiple languages, fetching and merging results from GitHub for each selected language. This enhances the search experience by supporting multi-language queries. (commit desc by copilot)
|
@offbeatjs is attempting to deploy a commit to the Max Programming's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
max-programming
left a comment
max-programming
left a comment
There was a problem hiding this comment.
Thanks for this implementation!
Here are a few requested changes
|
@offbeatjs I have reviewed the code and it's good but the implementation doesn't work. I have requested some changes to make the implementation perfect. Please let me know if you get stuck anywhere or you don't understand something ✌️ |
|
Thanks for the awesome insights ! I'll do this asap |
Co-authored-by: Usman Sabuwala <51731966+max-programming@users.noreply.github.com>
fixed the requested changes - added search button below - directory move from `/(public)/repos/[language]/_components` to `/(public)/repos/_components`
|
Could you check this up ? |
max-programming
left a comment
max-programming
left a comment
There was a problem hiding this comment.
Loving it so far @offbeatjs!
I've left a few comments for further improvements
- Replaced CSV params with Array - Moved the search bar up, and the button where it was.
Co-authored-by: Usman Sabuwala <51731966+max-programming@users.noreply.github.com>
Refactored the hero search form to separate the input and submit button, improving accessibility and layout. Added a loading skeleton for the repos page to enhance user experience during data fetching. Also simplified language parameter parsing in the repos page. - the repos/loading.tsx is exact same as the /repos/[language]/loading.tsx
|
Let me know if there are further changes needed. |
|
Some minor changes I'm gonna make before merging this in |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@all-contributors please add @offbeatjs for code, design, ideas |
|
I've put up a pull request to add @offbeatjs! 🎉 |
2 participants
Updated the hero component to allow users to select multiple programming languages via checkboxes, both from main and 'other' languages. Modified the repo page logic to accept and process multiple languages, fetching and merging results from GitHub for each selected language. This enhances the search experience by supporting multi-language queries.
(commit desc by copilot)
what's changed tl;dr